[zh-cn]: update the translation of Location hash property
#24798
Conversation
|
Preview URLs (comment last updated: 2025-01-08 01:15:18) |
| <a id="myAnchor" href="/zh-CN/docs/Location.href#示例">示例</a> | ||
| <script> | ||
| var anchor = document.getElementById("myAnchor"); | ||
| console.log(anchor.hash); // 返回'#Examples' | ||
| const anchor = document.getElementById("myAnchor"); | ||
| console.log(anchor.hash); // '#示例' | ||
| </script> |
There was a problem hiding this comment.
Is the example here appropriate?
The
Locationinterface is accessible via Document.location and Window.location respectively.
--- from TheLocationinterface
I don't think we should use an <a> element here, as <a> element is the implemetation of HTMLAnchorElement interface (not the Location interface).
Another issue on the content of this example. The hash property would be percent-encoded (see the test I made below), so the description above is also wrong 😢
It seems that only non-ascii characters will be encoded (details: mdn/content#37003)
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
added
the
merge conflicts 🚧
github-actions
bot
removed
the
merge conflicts 🚧
|
上游的错误还未修复，我先转草稿了 |
|
@yin1999 可以了，上游已经更新了，请帮我审查 |
没有，我上面提到的问题其实还未解决，现在只是在示例层面隐藏了这个问题。我希望能够优先解决 |
Description
Related issues and pull requests